Fix copy of BankName value + BranchId/BankId #5231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
suggested changes
Mar 11, 2021
There was a problem hiding this comment.
NACK - Please see my comments on the naming. Also for the future please have a look at https://chris.beams.io/posts/git-commit/. I'm not a great commit message writer myself, but I think there is some potential to grow 😉
desktop/src/main/java/bisq/desktop/components/TextFieldWithCopyIcon.java
Outdated
Show resolved
Hide resolved
|
Thanks for all the feedback @ripcurlx! |
Cha-cloud
reviewed
Apr 28, 2021
|
Hi @Cha-cloud not sure what you are trying to do but probably best to make a post on https://bisq.community/ or ask on Keybase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5200
This PR deals with cases like:
It would be trivial to add other instances if present.